Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add output type setting to apps #1905

Merged
merged 2 commits into from
May 11, 2023
Merged

Add output type setting to apps #1905

merged 2 commits into from
May 11, 2023

Conversation

jonatanklosko
Copy link
Member

馃悎

@jonatanklosko jonatanklosko changed the title Add output type option Add output type setting to apps May 10, 2023
@github-actions
Copy link

github-actions bot commented May 10, 2023 •
edited

Uffizzi Preview deployment-24869 was deleted.

@jonatanklosko
Copy link
Member Author

Since we will render everything by default, we probably no longer need the message about notebook being empty?

@josevalim
Copy link
Contributor

Yes, fine to remove it I think. Otherwise we can show it when booting!

@jonatanklosko jonatanklosko merged commit 022f395 into main May 11, 2023
7 checks passed
@jonatanklosko jonatanklosko deleted the jk-output-type branch May 11, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonatanklosko @josevalim