Fix lack of searchability in Spotlight #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I'm guessing, but seems like ElixirKit.swift and Livebook.swift will need updated to handle the following events: func applicationWillEnterForeground(_ application: UIApplication)
func applicationDidBecomeActive(_ application: UIApplication) |
|
Okay, 6e1ec56 should fix the issue where selecting Livebook from Spotlight when the App is already initialized failed to do anything. Now it'll open a new tab, same as clicking the menu icon and selecting open |
wojtekmach
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the lack of searchability in spotlight however there is a nuance that I have yet to figure out (may require executable changes?) I'm not a MacOS native developer, so I'm not certain.
Scenario: Livebook has not been opened
Spotlight -> Search Livebook -> Select the app
Result: Livebook creates the icon in the menu bar, opens Livebook in the browser
Desired: Works as expected
Scenario: Livebook has been opened, but the tab was closed (icon is in menu bar)
Spotlight -> Search Livebook -> Select the app
Result: Nothing happens
Desired: A new Livebook tab is opened in your browser