Show more details in type completion items #1975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- full type signature - type spec - insert with parantheses and var names
|
Uffizzi Preview |
|
There's something I'm not entirely sure about inserting types that have variables. Current solution is to insert them as they are defined. This of course means that sometimes the referenced variables' type names will not be known in the current context and cause errors. Another option would be to not include the variables, just place the cursor within the parenthesis - but this will most likely cause issues as well. 🤷♂️ |
Those are type arguments and we always want to specify a concrete type, no? So cursor in parentheses would be ideal for arity > 0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1974
This PR adds more details to type completion items