Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up assets and layout #2

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Set up assets and layout #2

merged 1 commit into from
Jan 7, 2021

Conversation

jonatanklosko
Copy link
Member

Quite boring initialization changes, so they don't introduce distraction in further PRs. I decided to go with tailwind as it allows for quick styling, yet doesn't bring predefined components. I also added prettier, so that we have opinionated formatting for JS/CSS code, similarly to Elixir formatter.

@josevalim
Copy link
Contributor

@jonatanklosko Tailwind generates a bunch of classes. It later looks at your HTML to remove the classes you don't use. Does this integration work with Phoenix?

@jonatanklosko
Copy link
Member Author

It allows for pointing to all files that may contain Tailwind classes:
https://github.com/elixir-nx/live_book/blob/d2104f130f8ab33455418349f43f90f9bf9fdaf9/assets/tailwind.config.js#L2-L7

Then it looks at those files looking for class-like pattern, so it should work perfectly fine here.

@jonatanklosko jonatanklosko merged commit 5877180 into main Jan 7, 2021
@jonatanklosko jonatanklosko deleted the initial-setup branch January 7, 2021 21:13
@josevalim josevalim mentioned this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants