Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support reading file entry content from the runtime #2044

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Support reading file entry content from the runtime #2044

merged 3 commits into from
Jul 7, 2023

Conversation

jonatanklosko
Copy link
Member

file_entry_read.mp4

@jonatanklosko jonatanklosko mentioned this pull request Jul 7, 2023
Closed
@github-actions
Copy link

github-actions bot commented Jul 7, 2023 •
edited

Uffizzi Preview deployment-30392 was deleted.

josevalim
josevalim approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we should talk about the API on the Kino side. :)

@jonatanklosko
Copy link
Member Author

@josevalim

image

@jonatanklosko jonatanklosko merged commit c02eb98 into main Jul 7, 2023
7 checks passed
@jonatanklosko jonatanklosko deleted the jk-files-read branch July 7, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonatanklosko @josevalim