New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serially setup apps before deploying from directory #2115

Merged

jonatanklosko merged 4 commits into main from jk-apps-cache

Jul 26, 2023

Member

jonatanklosko commented Jul 26, 2023

Closes #1749.


          Serially setup apps before deploying from directory

cd6ca3c

github-actions bot commented Jul 26, 2023 •

edited

Uffizzi Preview deployment-31852 was deleted.

josevalim reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

josevalim reviewed

View reviewed changes

lib/livebook/application.ex Show resolved Hide resolved

josevalim reviewed

View reviewed changes

lib/livebook/apps.ex Outdated Show resolved Hide resolved

josevalim reviewed

View reviewed changes

lib/livebook/release.ex Outdated Show resolved Hide resolved

josevalim approved these changes

View reviewed changes

Contributor

josevalim left a comment

LGTM, I have only dropped some nitpicks and they are not important after all :)

jonatanklosko and others added 2 commits

July 26, 2023 19:15


          Update README.md

426b2d9

Co-authored-by: José Valim <jose.valim@dashbit.co>

Up

16ede58

josevalim reviewed

View reviewed changes

lib/livebook/application.ex Outdated Show resolved Hide resolved

josevalim approved these changes

View reviewed changes


          Apply review comments

38d98f6

jonatanklosko merged commit 904ebd0 into main

7 checks passed

jonatanklosko deleted the jk-apps-cache branch

July 26, 2023 18:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment