Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement File Storage #2212

Merged
merged 35 commits into from
Sep 25, 2023
Merged

Implement File Storage #2212

merged 35 commits into from
Sep 25, 2023

Conversation

aleDsz
Copy link
Member

@aleDsz aleDsz commented Sep 18, 2023

Livebook.File.Systems.2.mp4

@aleDsz
New User should use the same id from session data
75e3447
@aleDsz
Make create_teams_file_system/2 public
7fc0e64
@aleDsz
Add file system topic docs
b1d8ca9
@aleDsz
Add function to list file systems from all hubs
1a01870
@aleDsz
Use the notebook hub to list file systems
df1a0c2
@aleDsz
Handle hub assignment to list hub file systems
b9f3d93
@aleDsz
Add ID to menu item elements from file system
70abc79
@aleDsz
Add tests for file systems menu
865083d
@aleDsz
Improve file entry spec from FileSystem protocol
ec724bf
@aleDsz
Keep :external_id nil as default
500343e
@aleDsz
Add :id from changeset
924050b
@aleDsz
Remove everything related to File System
0a776b9
@aleDsz
Add new hub routes to handle file systems
0674bb5
@aleDsz
Use alias instead
1581e69
@aleDsz
Add FileSystemListComponent
0426f67
@aleDsz
Add FileSystemFormComponent
66591dd
@aleDsz
Handle file system events
a87afba
@aleDsz
Implement file system components
3693247
@aleDsz
Add functions to help handling file system forms
8d5edcf
@aleDsz
Add tests
dc8e874
@aleDsz
Change flash message from created to added
9251981
@aleDsz
Improve confirm dialog when deleting a file system
db477ba
@aleDsz
Use file systems from notebook's hub
87edef6
@aleDsz
Use configure path based on current hub
fc916b6
@aleDsz
Rename from Delete to Detach
32cfbe9
@aleDsz
Fix specs
2ec8508
@aleDsz
Put region on changeset
8a64156
@aleDsz aleDsz self-assigned this Sep 18, 2023
josevalim
josevalim approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have only posted nitpicks. One comment though requires a bigger change to how the hub edit page works. :)

@josevalim josevalim mentioned this pull request Sep 20, 2023
Closed
jonatanklosko
jonatanklosko reviewed Sep 22, 2023
View reviewed changes
lib/livebook/hubs.ex Outdated Show resolved Hide resolved
josevalim
josevalim approved these changes Sep 23, 2023
View reviewed changes
Copy link
Contributor

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two minor nitpicks.

I would wait for @jonatanklosko's approval too. :)

josevalim
josevalim approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we will handle the migration in subsequent PRs. :)

@aleDsz aleDsz merged commit 96bf5dd into livebook-dev:main Sep 25, 2023
7 checks passed
@aleDsz aleDsz deleted the ale-ui-file-systems branch September 25, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

@jonatanklosko jonatanklosko jonatanklosko approved these changes

Assignees

@aleDsz aleDsz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aleDsz @josevalim @jonatanklosko