Support debounce option for inputs #2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Uffizzi Preview |
jonatanklosko
approved these changes
Sep 26, 2023
jonatanklosko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i would like to have control over the
phx-debouncesetting as a user for an input.Right now it defaults to
blur. I would expect an options same as Phoenix LiveView offers itThis is relevant for the inputs of type
rangetextareapassworddatenumbercolorurltexteach gets a
:debounceoption working the same as phoenix, but with a default value of"blur".This change is accompanied by a change in Kino, see livebook-dev/kino#347
I chose to add a fallback to
"blur"here as well, so there is no hard dependency on the Kino change:@attrs[:debounce] || "blur"This was a show stopper for me, when i tried to create a little type racing game in Livebook.