Add a connection error for offline hubs #2326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uffizzi Preview |
| @@ -38,7 +38,7 @@ defmodule Livebook.Hubs.Team do | |||
| field :org_key_id, :integer | |||
| field :teams_key, :string | |||
| field :org_public_key, :string | |||
| field :session_token, :string | |||
| field :session_token, :string, redact: true | |||
There was a problem hiding this comment.
Should we do that for the teams key too?
There was a problem hiding this comment.
The teams key is not strictly necessary and I thought having it in logs may help if someone loses it :P
| @@ -312,7 +312,7 @@ defmodule Livebook.Application do | |||
| Livebook.Hubs.save_hub(%Livebook.Hubs.Team{ | |||
| id: "team-#{name}", | |||
| hub_name: name, | |||
| hub_emoji: "💡", | |||
| hub_emoji: "⭐️", | |||
There was a problem hiding this comment.
If we want something more indicative, perhaps 🔓 or 📦, but it's whatever :D
jonatanklosko
approved these changes
Nov 8, 2023
|
💚 💙 💜 💛 ❤️ |
jonatanklosko
pushed a commit
that referenced
this pull request
Nov 9, 2023
jonatanklosko
pushed a commit
that referenced
this pull request
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.