Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid cookie naming - cookie names can't contain : #2539

Merged
merged 1 commit into from Apr 2, 2024
Merged

Fix invalid cookie naming - cookie names can't contain : #2539

merged 1 commit into from Apr 2, 2024

Conversation

slashmili
Copy link
Contributor

@slashmili slashmili commented Apr 2, 2024 •
edited

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024 •
edited

Uffizzi Preview deployment-49301 was deleted.

@slashmili
Copy link
Contributor Author

Just for the record the test passed on the original PR #2538

jonatanklosko
jonatanklosko approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@jonatanklosko jonatanklosko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@josevalim josevalim merged commit fa4addc into livebook-dev:main Apr 2, 2024
6 of 7 checks passed
@josevalim
Copy link
Contributor

💚 💙 💜 💛 ❤️

@scudelletti scudelletti deleted the mr/rename-cookie branch April 2, 2024 13:28
spunkedy pushed a commit to spunkedy/livebook that referenced this pull request Apr 22, 2024
@slashmili @spunkedy
Fix invalid cookie naming - cookie names can't contain : (livebook-de…
114ef5f 
…v#2539)

Closes livebook-dev#2537

RFCs:
* http://tools.ietf.org/html/rfc6265#section-4.1.1
* http://tools.ietf.org/html/rfc2616#section-2.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonatanklosko jonatanklosko jonatanklosko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem with lb:* cookies
3 participants
@slashmili @josevalim @jonatanklosko