Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dev assets watcher with cross-platform one #2553

Merged

Conversation

nixxquality
Copy link
Contributor

@nixxquality nixxquality commented Apr 8, 2024

Also added comments to make sure the two are linked by documentation now that they are no longer linked by function.

As suggested in #2544 (reply in thread)

Edit: For posterity, I used Phoenix's documentation (the :watchers section) as a reference.

Also added comments to make sure the two are linked by documentation now that they are no longer linked by function.
@CLAassistant
Copy link

CLAassistant commented Apr 8, 2024

CLA assistant check
All committers have signed the CLA.

assets/package.json Outdated Show resolved Hide resolved
config/dev.exs Outdated Show resolved Hide resolved
Copy link
Member

@jonatanklosko jonatanklosko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonatanklosko jonatanklosko merged commit 1cac107 into livebook-dev:main Apr 8, 2024
5 of 6 checks passed
spunkedy pushed a commit to spunkedy/livebook that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants