204 improvements #68
Merged
204 improvements #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great @theeyed! Do you mind adding a test for Then I think this one is good to go! |
|
Hey @theeyed, let me know if you don't have time to wrap this up. I don't want this to get stale. |
|
@matthewmueller got the original test passing. It required adding |
|
Excellent, thank you Alex! The Svelte version is needed because it starts off with a fresh node_modules directory every test run and this test depends on Svelte. |
matthewmueller
pushed a commit
that referenced
this pull request
May 23, 2022
* return 204 on nil error response * allow void view actions * fix controller test for 204 nil error response * Fix `TestEmptyActionWithView`
matthewmueller
pushed a commit
that referenced
this pull request
May 23, 2022
* return 204 on nil error response * allow void view actions * fix controller test for 204 nil error response * Fix `TestEmptyActionWithView`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10
nilerror responsesmap[string]interface{}{}to view Handler