Separate the errors for no ks specified and file not found #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's more helpful to the user if we don't combine "you didn't give me a kickstart file" and "you gave me a kickstart file, but it doesn't exist". In addition to giving separate error messages for the two cases, the "you gave me a kickstart file, but it doesn't exist" says what kickstart file it thinks it's looking for, which will help users catch syntax errors. Fixes livecd-tools#174
Conan-Kudo
approved these changes
Jan 15, 2021
|
Merged, thanks for the patch @funnelfiasco! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's more helpful to the user if we don't combine "you didn't give me a
kickstart file" and "you gave me a kickstart file, but it doesn't
exist".
In addition to giving separate error messages for the two cases, the
"you gave me a kickstart file, but it doesn't exist" says what kickstart
file it thinks it's looking for, which will help users catch syntax
errors.
Fixes #174