This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 17600 ]] Fix data grid refresh button in PI #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the com.livecode.pi.datagrid PI editor (which contained buttons to trigger refreshing the data grid and opening the row template stack) with a generic com.livecode.pi.action editor consisting of a single button, which forces an update whenever it is clicked. Call a custom setter when the buttons for these two data grid actions are pressed, to handle the resulting action.
|
@livecodeali The IDE library feels like the "wrong" place for the @livecode-vulcan review ok d50c0c9 |
|
@peter-b All the data-grid support stuff should probably be in a separate backscript I guess. But since the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the com.livecode.pi.datagrid PI editor (which
contained buttons to trigger refreshing the data grid and opening
the row template stack) with a generic com.livecode.pi.action editor
consisting of a single button, which forces an update whenever it is
clicked.
Call a custom setter when the buttons for these two data grid actions
are pressed, to handle the resulting action.