This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bugs 19951, 8228 ]] Line continuation formatting #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a number of edge cases where line continuations were no being formatted correctly. These were largely where a control structure was being continued over multiple lines. In one case the addition of a comment after a line continuation char caused poor formatting.
montegoulding
force-pushed
the
linecontinuationformatting
branch
from
e70ff42
to
6193589
Compare
|
@livecodeali as discussed I have added an indentation test harness to this PR |
montegoulding
commented
Sep 12, 2017
| put " " before line tIndex of tResult | ||
| end if | ||
| end repeat | ||
| TestDiagnostic tResult |
There was a problem hiding this comment.
Would have been nice to use the diff library here. I guess we could add it in develop.
|
@livecode-vulcan review ok 6193589 |
|
💙 review by @livecodeali ok 6193589 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a number of edge cases where line continuations were no
being formatted correctly. These were largely where a control structure
was being continued over multiple lines. In one case the addition of a
comment after a line continuation char caused poor formatting.