Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

Commit

Permalink
[[ Bug 21608 ]] Remove second break wait from invoke handler block
Browse files Browse the repository at this point in the history
This patch removes the call to `MCBrowserRunloopBreakWait` as we are
already using the LCB `post` command which does `MCEngineRunloopBreakWait`.

On iOS 12 this second break wait causes an app lockup that has been hard
to diagnose. Perhaps breaking an `MCFiberDispatch` `pthread_cond_wait` that
should not be broken.
  • Loading branch information
montegoulding committed Oct 19, 2018
1 parent 117740b commit 4f70c2f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 1 addition & 0 deletions docs/notes/bugfix-21608.md
@@ -0,0 +1 @@
# Fix application lockup when invoking a handler from the browser widget on iOS 12
3 changes: 0 additions & 3 deletions libbrowser/src/libbrowser_uiwebview.mm
Expand Up @@ -416,9 +416,6 @@ inline void MCBrowserRunBlockOnMainFiber(void (^p_block)(void))
OnJavaScriptCall([p_handler cStringUsingEncoding: NSUTF8StringEncoding], t_args);

MCBrowserListRelease(t_args);

// IM-2016-09-30: [[ Bug 18406 ]] Wake main thread to process handler call
MCBrowserRunloopBreakWait();
}
};
}
Expand Down

0 comments on commit 4f70c2f

Please sign in to comment.