This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
switchbutton: General rework #3684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still to do:
|
* The switchbutton now uses a "theme" property to control its theme. The "theme" defaults to "native", but can also be _temporarily_ set to "Android" or "iOS". However, the "theme" is not persisted over a save, so the switchbutton will always look "correct" when deployed. This is a temporary expedient to ensure that widgets look correct on mobile devices and can also have their mobile appearance previewed in the IDE. * The switchbutton now uses the "hilited"/"highlight"/etc. control property, the same as the built-in checkbox control. It uses the "hiliteChanged" message to indicate that the switchbutton has turned on or off. It's currently possible to change the status of the switchbutton _without_ emiting "hiliteChanged" by setting the "hilite" property directly. Maybe this is wrong. * The different Android colour themes have gone, and the switchbutton now uses "my background paint", "my border paint" and "my highlight paint" instead (painting in layers where necessary to achieve variation in shade). * The switchbutton is now the same size in both the Android and iOS styles. * Only one set of drawing logic is used for both the Android and iOS styles, controlled by the `kGeometry` and `kPaints` constants
peter-b
force-pushed
the
switchbutton-rework
branch
from
1b877dd
to
c2d8681
Compare
|
@livecodeali I think this is good to go. |
|
@livecode-vulcan review ok c2d8681 |
|
💙 review by @livecodeali ok c2d8681 |
livecode-vulcan
added a commit
that referenced
this pull request
Mar 8, 2016
switchbutton: General rework * The switchbutton now uses a "theme" property to control its theme. The "theme" defaults to "native", but can also be _temporarily_ set to "Android" or "iOS". However, the "theme" is not persisted over a save, so the switchbutton will always look "correct" when deployed. This is a temporary expedient to ensure that widgets look correct on mobile devices and can also have their mobile appearance previewed in the IDE. * The switchbutton now uses the "hilited"/"highlight"/etc. control property, the same as the built-in checkbox control. It uses the "hiliteChanged" message to indicate that the switchbutton has turned on or off. It's currently possible to change the status of the switchbutton _without_ emiting "hiliteChanged" by setting the "hilite" property directly. Maybe this is wrong. * The different Android colour themes have gone. * The switchbutton is now the same size in both the Android and iOS styles.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The switchbutton now uses a "theme" property to control its
theme. The "theme" defaults to "native", but can also be
temporarily set to "Android" or "iOS". However, the "theme"
is not persisted over a save, so the switchbutton will always
look "correct" when deployed.
This is a temporary expedient to ensure that widgets look
correct on mobile devices and can also have their mobile
appearance previewed in the IDE.
The switchbutton now uses the "hilited"/"highlight"/etc. control
property, the same as the built-in checkbox control. It uses the
"hiliteChanged" message to indicate that the switchbutton has
turned on or off.
It's currently possible to change the status of the switchbutton
without emiting "hiliteChanged" by setting the "hilite"
property directly. Maybe this is wrong.
The different Android colour themes have gone.
The switchbutton is now the same size in both the Android and iOS
styles.