This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
Complete tokenOffset implementation #4291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montegoulding
force-pushed
the
tokenoffset
branch
from
e2d2248
to
b49362f
Compare
|
@livecode-vulcan review ok b49362f |
|
💙 review by @livecodeali ok b49362f |
livecode-vulcan
added a commit
that referenced
this pull request
Jul 18, 2016
Complete tokenOffset implementation It looks like I found a half implemented feature here. It's documented and as you can see from the limited amount I needed to do was mostly implemented. I'll rebase on whatever seems appropriate once I get some feedback on which version it should go into.
|
@livecode-vulcan retry b49362f |
livecode-vulcan
added a commit
that referenced
this pull request
Jul 18, 2016
Complete tokenOffset implementation It looks like I found a half implemented feature here. It's documented and as you can see from the limited amount I needed to do was mostly implemented. I'll rebase on whatever seems appropriate once I get some feedback on which version it should go into.
|
Can I? @livecode-vulcan retry b49362f |
|
@montegoulding Don't forget that @livecode-vulcan only pays attention when its name appears at the start of a line! @livecode-vulcan retry b49362f |
livecode-vulcan
added a commit
that referenced
this pull request
Jul 20, 2016
Complete tokenOffset implementation It looks like I found a half implemented feature here. It's documented and as you can see from the limited amount I needed to do was mostly implemented. I'll rebase on whatever seems appropriate once I get some feedback on which version it should go into.
|
Aha... I knew there was a rule but I forgot what it was... thanks @peter-b |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like I found a half implemented feature here. It's documented and as you can see from the limited amount I needed to do was mostly implemented. I'll rebase on whatever seems appropriate once I get some feedback on which version it should go into.