This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
[Bug 13180] Allow GPS access from Android Browser Control #6374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: You still have to check the Location permissions in the Android Standalone Settings
…to bugfix-13180
| @@ -321,10 +321,14 @@ public void onHideCustomView() | |||
| m_custom_view_callback = null; | |||
| } | |||
| } | |||
| public void onGeolocationPermissionsShowPrompt(String origin, GeolocationPermissions.Callback callback) { | |||
| callback.invoke(origin, true, false); | |||
There was a problem hiding this comment.
@livecodepanos I'm thinking we should be presenting a dialog here
There was a problem hiding this comment.
Sure, I'll look into adding one
|
@livecode-vulcan review ok 5e91c0f |
|
💙 review by @montegoulding ok 5e91c0f |
livecode-vulcan
added a commit
that referenced
this pull request
Mar 12, 2018
[Bug 13180] Allow GPS access from Android Browser Control Note: You still have to check the Location permissions in the Android Standalone Settings
|
😎 test success 5e91c0f
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: You still have to check the Location permissions in the Android Standalone Settings