This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 21672 ]] Disable auto content inset adjustment on iOS 11 scroller #6776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
livecodeali
force-pushed
the
bugfix-21672
branch
from
48ac665
to
75fc598
Compare
| @@ -752,7 +752,12 @@ bool MCScrollViewGetContentOffset(UIScrollView *p_view, int32_t &r_x, int32_t &r | |||
| t_view = [[UIScrollView alloc] initWithFrame: CGRectMake(0, 0, 0, 0)]; | |||
| if (t_view == nil) | |||
| return nil; | |||
|
|
|||
|
|
|||
| if (@available(iOS 11.0, *)) { | |||
There was a problem hiding this comment.
@livecodeali I think you also need to wrap this in a pre-processor macro because UIScrollViewContentInsetAdjustmentNever won't be available for some of the SDKs we still build against:
#if __IPHONE_OS_VERSION_MAX_ALLOWED > 110000
livecodeali
force-pushed
the
bugfix-21672
branch
from
75fc598
to
bb81c3d
Compare
|
@livecode-vulcan review ok bb81c3d |
|
💙 review by @montegoulding ok bb81c3d |
livecode-vulcan
added a commit
that referenced
this pull request
Nov 6, 2018
[[ Bug 21672 ]] Disable auto content inset adjustment on iOS 11 scroller
|
😎 test success bb81c3d
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.