This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
[[ Win 64 ]] Add support for 64 bit standalones on Windows #6821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrisan
changed the title
abrisan
force-pushed
the
feature-deploy64
branch
3 times, most recently
from
4e905f3
to
1dfc923
Compare
abrisan
force-pushed
the
feature-deploy64
branch
2 times, most recently
from
ee36293
to
de34245
Compare
montegoulding
force-pushed
the
feature-deploy64
branch
11 times, most recently
from
7d5ac4d
to
8f6e5f2
Compare
montegoulding
changed the title
This patch enables building standalones with the Windows 64 bit standalone engine.
This patch adds support to the build tools for building the x86_64 installer for Windows.
This patch updates the package script to allow for multiple windows architectures to be built.
This patch amends the standalone builder scripts to allow building of a Windows x86_64 standalone.
This patch adds the Windows x86_64 Installer and Server for each edition to the upload to staging. It also updates the x86 builds with their new names.
GYP seems to be choking on the the java source listed in sources in the encode_support target. Removing them resolves the issue and the files were already listed in the target action inputs etc.
This patch updates the `_internal sign windows` command for 64 bit executables. The patch also updates the deploy command to reuse: - `MCDeployWindowsPEHeaderOffset` which does some basic DOS header checking and extraction of the PE header offset. - `MCDeployWindowsArchitecture` which does some basic NT header checking and determiniation of the executable architecture.
This patch updates the windows manifest for the installer so that it will load the correct architecture version of COMCTL32.dll.
montegoulding
force-pushed
the
feature-deploy64
branch
from
8f6e5f2
to
78bd957
Compare
|
@livecode-vulcan review ok 78bd957 |
|
💙 review by @livecodeali ok 78bd957 |
livecode-vulcan
added a commit
that referenced
this pull request
May 7, 2019
[[ Win 64 ]] Add support for 64 bit standalones on Windows
|
😎 test success 78bd957
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.