This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
[21843] Ensure mobileComposeMail attachment is not lost when Gmail app is used #6887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/notes/bugfix-21843.md
Outdated
| @@ -0,0 +1 @@ | |||
| Ensure mobileComposeMail attachment is not lost when gmail app is used to send the email | |||
There was a problem hiding this comment.
@livecodepanos missing # here
|
@livecode-vulcan review ok 224b9c7 |
|
💙 review by @montegoulding ok 224b9c7 |
livecode-vulcan
added a commit
that referenced
this pull request
Feb 26, 2019
[21843] Ensure mobileComposeMail attachment is not lost when Gmail app is used Due to recent changes in Android permission model, it was no longer possible on devices running Android >= 6.0 to send an attachment using `mobileComposeMail` when the receiver app is Gmail. This patch ensures that our own implementation of FileProvider (a subclass of ContentProvider) does these necessary 3 things for successfully sharing an attachment using `mobileComposeMail`: 1. Define the FileProvider in your AndroidManifest file (--> added meta-data tag) 2. Create an XML file that contains all paths that the FileProvider will share with other applications (see `android-file_provider_paths.xml`) 3. Ensure a valid URI is created in the Intent (see `m_content_uri_base`) For more details, see https://developer.android.com/reference/android/support/v4/content/FileProvider.html?hl=en This patch is tested on 2 Android devices, running Android 5.1.1 and Android 9.
|
😎 test success 224b9c7
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to recent changes in Android permission model, it was no longer possible on devices running Android >= 6.0 to send an attachment using
mobileComposeMailwhen the receiver app is Gmail.This patch ensures that our own implementation of FileProvider (a subclass of ContentProvider) does these necessary 3 things for successfully sharing an attachment using
mobileComposeMail:android-file_provider_paths.xml)m_content_uri_base)For more details, see
https://developer.android.com/reference/android/support/v4/content/FileProvider.html?hl=en
This patch is tested on 2 Android devices, running Android 5.1.1 and Android 9.