Correctly apply elementVolume on attach for webaudioMix (#922)

* Correctly apply elementVolume on attach for webaudioMix * Create dirty-parrots-kneel.md
livekit · Nov 3, 2023 · c833637 · c833637
1 parent 89557f4
commit c833637
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/.changeset/dirty-parrots-kneel.md b/.changeset/dirty-parrots-kneel.md
@@ -0,0 +1,5 @@
+---
+"livekit-client": patch
+---
+
+Correctly apply elementVolume on attach for webaudioMix
diff --git a/src/room/track/RemoteAudioTrack.ts b/src/room/track/RemoteAudioTrack.ts
@@ -101,9 +101,7 @@ export default class RemoteAudioTrack extends RemoteTrack {
     } else {
       super.attach(element);
     }
-    if (this.elementVolume) {
-      element.volume = this.elementVolume;
-    }
+
     if (this.sinkId && supportsSetSinkId(element)) {
       /* @ts-ignore */
       element.setSinkId(this.sinkId);
@@ -114,6 +112,12 @@ export default class RemoteAudioTrack extends RemoteTrack {
       element.volume = 0;
       element.muted = true;
     }
+
+    if (this.elementVolume) {
+      // make sure volume setting is being applied to the newly attached element
+      this.setVolume(this.elementVolume);
+    }
+
     return element;
   }