-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stopProcessor
param to replaceTrack function
#1040
Conversation
🦋 Changeset detectedLatest commit: 7faf4b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
src/room/track/LocalTrack.ts
Outdated
@@ -221,7 +221,7 @@ export default abstract class LocalTrack< | |||
return this; | |||
} | |||
|
|||
async replaceTrack(track: MediaStreamTrack, userProvidedTrack = true) { | |||
async replaceTrack(track: MediaStreamTrack, userProvidedTrack = true, stopProcessor = true) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if we want to do this now.. but might be cleaner to support a ReplaceOptions object instead of multiple args? I really wish JS supported keyword args.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right, that would be cleaner!
…ivekit/client-sdk-js into lukas/make-processor-stop-configurable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
No description provided.