Forward leave reason of disconnected events #304
Conversation
🦋 Changeset detectedLatest commit: f3ae020 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
src/room/Room.ts
Outdated
| @@ -15,6 +15,7 @@ import { | |||
| import { | |||
| ConnectionQualityUpdate, | |||
| JoinResponse, | |||
| LeaveRequest_LeaveReason, | |||
There was a problem hiding this comment.
what do you think about exporting a type-defed version of this? i.e. type DisconnectedReason = LeaveRequest_LeaveReason, it seems a bit more friendly for users to import.
There was a problem hiding this comment.
sounds good! was missing the export anyways...
There was a problem hiding this comment.
or.. maybe I should just name that DisconnectReason in the proto? 🤔 wdyt?
There was a problem hiding this comment.
renaming in the proto seems slightly cleaner, but no strong opinion either way.
There was a problem hiding this comment.
yeah, you are right.. it'll be consistent across platforms.. I'll do that and then merge.
There was a problem hiding this comment.
yeah, you are right.. it'll be consistent across platforms. will update.
client implementation for livekit/protocol#139