Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable simulcast if an user provides an empty array for custom simulcast layers #382

Merged
merged 2 commits into from
Aug 5, 2022

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Aug 5, 2022

makes it possible to disable screen share simulcast by setting screenShareSimulcastLayers to [] while simulcast is still being used for camera publications (and vice versa)

@changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2022

🦋 Changeset detected

Latest commit: f07ec98

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@lukasIO lukasIO merged commit 8499723 into main Aug 5, 2022
@lukasIO lukasIO deleted the lukas/disable-simulcast-screenshare branch August 5, 2022 16:07
@github-actions github-actions bot mentioned this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants