Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify more explicit browser targets #405

Merged
merged 6 commits into from
Aug 19, 2022
Merged

Specify more explicit browser targets #405

merged 6 commits into from
Aug 19, 2022

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Aug 19, 2022

...as part of the efforts to increase compatibility.
Firefox version above 53 because below that it adds ~10kb on the gzipped bundle size.
FF v53 was released in 2017, so I think this is an ok trade off.

This PR is also removing the defaults setting of browserslist, which means some browsers like opera, baidu, kaios aren't considered at all anymore for transpilation. The reasoning behind this is, that they do not support the necessary webRTC APIs anyways to use the library.

@changeset-bot
Copy link

changeset-bot bot commented Aug 19, 2022

🦋 Changeset detected

Latest commit: c1fcea1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lukasIO lukasIO requested a review from davidzhao August 19, 2022 11:35
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work!

@lukasIO lukasIO merged commit 2983939 into main Aug 19, 2022
@lukasIO lukasIO deleted the lukas/compat-browsers branch August 19, 2022 17:09
@github-actions github-actions bot mentioned this pull request Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants