Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move monitor APIs into parent classes #410

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Move monitor APIs into parent classes #410

merged 2 commits into from
Aug 23, 2022

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Aug 22, 2022

follow up on #393 and unifies the approach to use an interval instead of setTimeout also for local tracks, making sure that the aren't multiple parallel monitoring loops running.

@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2022

🦋 Changeset detected

Latest commit: d5a0461

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@lukasIO lukasIO changed the title move monitor apis in parent classes Move monitor APIs in parent classes Aug 23, 2022
@lukasIO lukasIO changed the title Move monitor APIs in parent classes Move monitor APIs into parent classes Aug 23, 2022
@lukasIO lukasIO merged commit 5b31a19 into main Aug 23, 2022
@lukasIO lukasIO deleted the lukas/clean-monitor branch August 23, 2022 11:11
@github-actions github-actions bot mentioned this pull request Aug 23, 2022
max-b pushed a commit to Invisv-Privacy/client-sdk-js that referenced this pull request Oct 4, 2022
* move monitor apis in parent classes

* changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants