Add RoomEvent.Connected, fix connect future
#431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 46ab7e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
davidzhao
approved these changes
Sep 12, 2022
| @@ -171,7 +171,7 @@ class Room extends (EventEmitter as new () => TypedEmitter<RoomEventCallbacks>) | |||
| }) | |||
| .on(EngineEvent.Resumed, () => { | |||
| this.setAndEmitConnectionState(ConnectionState.Connected); | |||
| this.reconnectFuture?.resolve(); | |||
| this.reconnectFuture?.resolve?.(); | |||
Merged
max-b
pushed a commit
to Invisv-Privacy/client-sdk-js
that referenced
this pull request
Oct 4, 2022
* add connected event, fix connect future * changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding the connect future fix, we've seen a couple of instances of
b.reject is not definedwhen quickly connecting/disconnecting (one of these got raised with react's strict mode).When constructing a future from a promise, previously there was no way to actually reject it from the future. This is fixed by not accepting a promise, but rather the function that runs within the promise in the future constructor.
Also removed the
!from the resolve and reject, as we cannot be sure those are actually populated.In order to clean up stuff, there's an
onFinallyoptional callback in the constructor.