Mute track if ended event has been fired #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 207cadd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
davidzhao
approved these changes
Oct 28, 2022
| @@ -965,6 +965,7 @@ export default class LocalParticipant extends Participant { | |||
| this.unpublishTrack(track); | |||
| } else if (track.isUserProvided) { | |||
| await track.pauseUpstream(); | |||
| await track.mute(); | |||
There was a problem hiding this comment.
if we are muting the track, is pauseUpstream still needed?
There was a problem hiding this comment.
the only reason I left it in is to not break the behaviour for people who have relied on those events to be emitted.
But realised just now, that it's marked as an internal event anyways, so should be safe to remove!
Merged
max-b
pushed a commit
to Invisv-Privacy/client-sdk-js
that referenced
this pull request
Dec 5, 2022
…ck (livekit#498) * mute track if ended event has been fired * remove pauseUpstream on ended * changeset
max-b
pushed a commit
to Invisv-Privacy/client-sdk-js
that referenced
this pull request
Dec 5, 2022
…ck (livekit#498) * mute track if ended event has been fired * remove pauseUpstream on ended * changeset
max-b
pushed a commit
to Invisv-Privacy/client-sdk-js
that referenced
this pull request
Dec 9, 2022
…ck (livekit#498) * mute track if ended event has been fired * remove pauseUpstream on ended * changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #496
Considering the fact that after the
endedevent we will not be able to reuse that track again ever, we might as well mute it to surface the fact that the local publication isn't currently active anymore.