Add support for local priority in presets #677
Conversation
🦋 Changeset detectedLatest commit: 221f819 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| super(); | ||
| this.pc = new RTCPeerConnection(config); | ||
| this.pc = isChromiumBased() |
There was a problem hiding this comment.
should this be
isChromiumBased() ? new RTCPeerConnection(config, mediaConstraints) : new RTCPeerConnection(config)
There was a problem hiding this comment.
ah, of course, thanks!
| encodings = [ | ||
| { | ||
| maxBitrate: opts.audioBitrate, | ||
| maxBitrate: opts.audioPreset?.maxBitrate ?? opts.audioBitrate, |
There was a problem hiding this comment.
should we avoid setting this field if left as undefined? I know we had issues with FF before with leaving FPS as undefined.
There was a problem hiding this comment.
opts gets merged with trackPublishDefaults in publishTrack so it should always be defined!
just did some tests on chrome: |
In order to satisfy TS I had to update to v5.0.0 which makes this PR a bit unwieldy.
TS 5.0 changes are only to make type imports explicit (we had this setting before already, but 5.0 caught a lot more cases)
This PR adds support to construct video and audio presets with an additional
priorityoption which (on supported browsers) tells the browser about how to distribute available resources (cpu + network) between different tracks.audioBitratesetting onTrackPublishDefaultsin favor ofaudioPresetthat now includespriorityhigh, screen share video tracksmediumand camera video trackslow