-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase default adaptiveStream pixelDensity on high-density screens #735
Conversation
Mobile devices typically use high density screens (2.5-3+). On these platforms, using default CSS dimensions tends to produce less than ideal streaming quality when using adaptiveStream defaults.
🦋 Changeset detectedLatest commit: 44a5024 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
Can we switch to |
I'm trying to avoid a change in behavior on desktop systems. If we defaulted to screen, it will increase the bandwidth consumption on most displays today. On mobile, it'll mean fetching 720p by default for a video tile that takes about 200 css pixels. Maybe this is a change we make for 2.0? as more efficient codecs are used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that makes sense!
we should probably do this with a minor changeset, as it is changing current default behaviour on mobile
Mobile devices typically use high density screens (2.5-3+). On these platforms, using default CSS dimensions tends to produce less than ideal streaming quality when using adaptiveStream defaults.