Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only check for setSinkId support on AudioContext if webaudiomix is enabled #787

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Only check for setSinkId support on AudioContext if webaudiomix is enabled #787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1afd170
Only check for setSinkId support on AudioContext if webaudiomix
lukasIO Jul 13, 2023
5835c3d
Create tame-drinks-arrive.md
lukasIO Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tame-drinks-arrive.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"livekit-client": patch
---

Only check for setSinkId support on AudioContext if webaudiomix is enabled
2 changes: 1 addition & 1 deletion src/room/Room.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,7 +834,7 @@ class Room extends EventEmitter<RoomEventCallbacks> {
} else if (kind === 'audiooutput') {
if (
(!supportsSetSinkId() && !this.options.expWebAudioMix) ||
(this.audioContext && !('setSinkId' in this.audioContext))
(this.options.expWebAudioMix && this.audioContext && !('setSinkId' in this.audioContext))
) {
throw new Error('cannot switch audio output, setSinkId not supported');
}
Expand Down
Loading