Convert pauseUpstream and resumeUpstream to regular class methods #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 29cd2fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
davidzhao
approved these changes
Aug 7, 2023
cnderrauber
approved these changes
Aug 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until recently we were passing
this.pauseUpstreamdirectly to an event handler oftrack.on('mute', this.pauseUpstream). Since we don't do this anymore we can convert them to regular class methods, which allows us to callsuper.*Upstreamin child classes. This is needed for a clean implementation of #829.This does change binding behaviour when the method is passed around directly to e.g. event handlers, so it warrants a minor version bump.
This change aligns those APIs with how we define
muteandunmute, those are regular class methods, too.