Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Safari reporting wrong initial track resolution #898

Merged
merged 5 commits into from
Oct 23, 2023

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Oct 23, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2023

🦋 Changeset detected

Latest commit: 39b9a22

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 76.62 KB (+0.03% 🔺)
dist/livekit-client.umd.js 82.2 KB (+0.03% 🔺)

@@ -163,6 +163,12 @@ export default abstract class LocalTrack extends Track {
throw new Error('cannot get dimensions for audio tracks');
}

if (getBrowser()?.os === 'iOS') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow... just.... 🤯

@lukasIO lukasIO merged commit 40ccf2a into main Oct 23, 2023
3 checks passed
@lukasIO lukasIO deleted the lukas/expose-video-dimensions branch October 23, 2023 17:37
@github-actions github-actions bot mentioned this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants