Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 893: broken livekit-client in Angular #901

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Fix issue 893: broken livekit-client in Angular #901

merged 4 commits into from
Oct 26, 2023

Conversation

pabloFuente
Copy link
Contributor

Fixes issue #893

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2023

🦋 Changeset detected

Latest commit: d235647

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lukasIO
Copy link
Contributor

lukasIO commented Oct 25, 2023

@pabloFuente thanks! the pipeline is still failing because of the formatter check not succeeding. You'll need to run yarn format to fix it.

@lukasIO lukasIO self-requested a review October 25, 2023 15:06
@pabloFuente
Copy link
Contributor Author

Done

Copy link
Contributor

@lukasIO lukasIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you!

@lukasIO lukasIO merged commit 99911ea into livekit:main Oct 26, 2023
3 checks passed
@github-actions github-actions bot mentioned this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants