Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async/await syntax support #168

Merged
merged 10 commits into from Dec 28, 2022
Merged

Async/await syntax support #168

merged 10 commits into from Dec 28, 2022

Conversation

hiroshihorie
Copy link
Member

@hiroshihorie hiroshihorie commented Dec 13, 2022 •
edited

Apple's async / await syntax instead of Promises.

@hiroshihorie hiroshihorie changed the title Async await syntax support Async/await syntax support Dec 13, 2022
@hiroshihorie hiroshihorie mentioned this pull request Dec 13, 2022
Closed
@hiroshihorie hiroshihorie marked this pull request as ready for review December 27, 2022 14:07
@davidzhao
Copy link
Member

Any reason these are defined as extensions vs function definitions in the same file? I remember trying to look for some functions earlier.. and it was not intuitive that they were defined in extensions.

@hiroshihorie
Copy link
Member Author

Just like the ObjCSupport.swift I'm splitting the code into multiple files not to overcrowd the main files.
But I can adjust to your preference , which do you prefer ?

@hiroshihorie hiroshihorie merged commit 3ce23a1 into main Dec 28, 2022
@hiroshihorie hiroshihorie deleted the async-await branch December 28, 2022 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao davidzhao approved these changes

@cloudwebrtc cloudwebrtc Awaiting requested review from cloudwebrtc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hiroshihorie @davidzhao