Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust AVAudioSession CategoryOptions (include .mixWithOthers) #228

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Adjust AVAudioSession CategoryOptions (include .mixWithOthers) #228

merged 1 commit into from
Jul 13, 2023

Conversation

hiroshihorie
Copy link
Member

Connection drops without this option when playing other audio.
#227 (comment)

cloudwebrtc
cloudwebrtc approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@cloudwebrtc cloudwebrtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hiroshihorie hiroshihorie merged commit a4f4c01 into main Jul 13, 2023
1 check passed
@hiroshihorie hiroshihorie deleted the fix-audio-category-options branch July 13, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudwebrtc cloudwebrtc cloudwebrtc approved these changes

@davidzhao davidzhao Awaiting requested review from davidzhao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hiroshihorie @cloudwebrtc