Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smooth transition for VideoView capture position update #383

Merged
merged 10 commits into from
May 27, 2024

Conversation

hiroshihorie
Copy link
Member

@hiroshihorie hiroshihorie commented May 24, 2024

When capture position update is detected:

  1. Creates a secondary renderer view in the back of primary renderer
  2. Renders some frames (2 frames) on secondary renderer
  3. Executes animated primary secondary renderer swap
  4. Sets rendering back to primary renderer
  • Ensure clean up
  • Add animation preference properties
Before this PR CrossDissolve Flip
transition-before.mov
transition-crossdissolve.mov
transition-flip.mov

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! smooth as 🧈

@hiroshihorie hiroshihorie merged commit 7dd9a43 into main May 27, 2024
4 of 7 checks passed
@hiroshihorie hiroshihorie deleted the videoview-smooth-position-transition branch May 27, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants