Mark appropriate classes as @stable or @immutable (#11)

livekit · Mar 28, 2024 · 2fdd06b · 2fdd06b
1 parent e96d599
commit 2fdd06b
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 1 deletion.
diff --git a/livekit-compose-components/src/main/java/io/livekit/android/compose/chat/Chat.kt b/livekit-compose-components/src/main/java/io/livekit/android/compose/chat/Chat.kt
@@ -155,4 +155,4 @@ fun rememberChat(room: Room = RoomLocal.current): Chat {
 
 private val json = Json {
     ignoreUnknownKeys = true
-}
+}
diff --git a/livekit-compose-components/src/main/java/io/livekit/android/compose/flow/DataHandler.kt b/livekit-compose-components/src/main/java/io/livekit/android/compose/flow/DataHandler.kt
@@ -17,6 +17,7 @@
 package io.livekit.android.compose.flow
 
 import androidx.compose.runtime.Composable
+import androidx.compose.runtime.Stable
 import androidx.compose.runtime.mutableStateOf
 import androidx.compose.runtime.remember
 import androidx.compose.runtime.rememberCoroutineScope
@@ -36,6 +37,7 @@ data class DataSendOptions(val reliability: DataPublishReliability, val identiti
  *
  * @see rememberDataMessageHandler
  */
+@Stable
 class DataHandler(
     /** A flow for all the [DataMessage] received. */
     val messageFlow: Flow<DataMessage>,

diff --git a/...pose-components/src/main/java/io/livekit/android/compose/state/RememberParticipantInfo.kt b/...pose-components/src/main/java/io/livekit/android/compose/state/RememberParticipantInfo.kt
@@ -17,6 +17,7 @@
 package io.livekit.android.compose.state
 
 import androidx.compose.runtime.Composable
+import androidx.compose.runtime.Immutable
 import androidx.compose.runtime.collectAsState
 import androidx.compose.runtime.remember
 import io.livekit.android.compose.local.requireParticipant
@@ -26,6 +27,7 @@ import io.livekit.android.util.flow
 /**
  * Holder for basic [Participant] information.
  */
+@Immutable
 data class ParticipantInfo(
     val name: String?,
     val identity: Participant.Identity?,

diff --git a/...kit-compose-components/src/main/java/io/livekit/android/compose/state/RememberRoomInfo.kt b/...kit-compose-components/src/main/java/io/livekit/android/compose/state/RememberRoomInfo.kt
@@ -17,6 +17,7 @@
 package io.livekit.android.compose.state
 
 import androidx.compose.runtime.Composable
+import androidx.compose.runtime.Immutable
 import androidx.compose.runtime.collectAsState
 import androidx.compose.runtime.remember
 import io.livekit.android.compose.local.requireRoom
@@ -26,6 +27,7 @@ import io.livekit.android.util.flow
 /**
  * Holder for basic [Room] information.
  */
+@Immutable
 data class RoomInfo(
     val name: String?,
     val metadata: String?,

diff --git a/livekit-compose-components/src/main/java/io/livekit/android/compose/ui/MediaDropdownMenu.kt b/livekit-compose-components/src/main/java/io/livekit/android/compose/ui/MediaDropdownMenu.kt
@@ -23,6 +23,7 @@ import androidx.compose.material3.ExposedDropdownMenuDefaults
 import androidx.compose.material3.Text
 import androidx.compose.material3.TextField
 import androidx.compose.runtime.Composable
+import androidx.compose.runtime.Immutable
 import androidx.compose.runtime.LaunchedEffect
 import androidx.compose.runtime.MutableState
 import androidx.compose.runtime.getValue
@@ -34,6 +35,7 @@ import androidx.compose.ui.platform.LocalContext
 import livekit.org.webrtc.Camera1Enumerator
 import livekit.org.webrtc.Camera2Enumerator
 
+@Immutable
 data class DeviceState(val selectedDeviceId: String, val deviceIds: List<String>)
 
 /**