Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink bundle size for LiveKitRoom #451

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Shrink bundle size for LiveKitRoom #451

merged 1 commit into from
Apr 19, 2023

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Apr 19, 2023

If users decide to only import LiveKitRoom we want to try to use as little resources as possible.
Some of our dependencies were either unnecessary or caused the bundle to bloat even when not being imported (failed tree shaking). This PR addresses the lowest hanging fruits in that regard so that importing LiveKitRoom by itself only takes ~1.9kB.

@changeset-bot
Copy link

changeset-bot bot commented Apr 19, 2023

⚠️ No Changeset found

Latest commit: 9fd99be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lukasIO lukasIO requested a review from Ocupe April 19, 2023 08:29
Copy link
Contributor

@Ocupe Ocupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukasIO lukasIO merged commit 44f0b0d into main Apr 19, 2023
@lukasIO lukasIO deleted the lukas/bundle branch April 19, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants