Fix duplicated incoming audio when using AudioTrack renderer and its muted property #855
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #845
With
webAudioMix
enabled by default, we're relying on the fact that the HTMLAudioElement staysmuted
in the DOM as the audio playback itself will be happening through the WebAudio API.However, we didn't extract the
muted
property from the AudioTrackProps before re-assigning them to the<AudioTrack />
component. This could lead to the audio being played back both through the HTMLAudioElement and the WebAudio API.