Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create emailregex in components-core instead of using a dedicated package #895

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Jun 14, 2024

No description provided.

Copy link

changeset-bot bot commented Jun 14, 2024

🦋 Changeset detected

Latest commit: db404c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@livekit/components-core Patch
@livekit/components-react Patch
@livekit/component-example-next Patch
@livekit/components-js-docs Patch
@livekit/component-docs-storybook Patch
@livekit/components-docs-gen Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 14, 2024

size-limit report 📦

Path Size
LiveKitRoom only 1.87 KB (0%)
LiveKitRoom with VideoConference 28.24 KB (0%)
All exports 33.64 KB (-0.05% 🔽)

@lukasIO lukasIO requested review from Ocupe and davidzhao June 14, 2024 08:37
Copy link
Contributor

@Ocupe Ocupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It would be nice to have some sanity tests to check for correctness. Since regex are a common source of bugs. 😜

@lukasIO lukasIO merged commit f094912 into main Jun 14, 2024
3 checks passed
@lukasIO lukasIO deleted the lukas/email-update branch June 14, 2024 09:58
@github-actions github-actions bot mentioned this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants