Guard against ParticipantUpdate sent before JoinResponse #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnderrauber
approved these changes
Dec 29, 2022
boks1971
reviewed
Dec 29, 2022
pkg/sfu/downtrack.go
Outdated
| // 2. in case of session migration, participant migrate from other node, video track should | ||
| // be resumed with same participant, set flush=false since we don't need to flush decoder. | ||
| // 1. When transceiver is reused by other participant's video track, | ||
| // set flush=true to avoid previous video shows before previous stream is displayed. |
There was a problem hiding this comment.
not related to this PR, but looks like this comment should say to avoid previous video shows before new stream is displayed
There was a problem hiding this comment.
cool, I'll change. this was formatted by running mage deadlock and then mage sync
boks1971
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not want to send participants any signal messages prior to JoinResponse.