Minor tweaks to frame based stream tracker. #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do status check if the interval is more than 98% of eval interval. If the eval interval is set close to check interval, things get off by a few ms and it misses a check window. Add some tolerance. Could not find a good way to use inter-layer fps to eliminate any config. Things change randomly (at least under NLC testing) which makes it hard to rely on inter-layer. And browser variations like some browsers stopping lower layers makes it error prone. The single config of `MinFPS` with sane defaults seems like it could be the way. Hopefully, the default will be good for an overwhelming majoirty of use cases. If not, we can look at adding one config to `VideoLayers` in `TrackInfo` for `MinFPS` and override the server side config per track. That is a small enough change to the protocol and fairly straight forward to document/understand.
cnderrauber
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could not find a good way to use inter-layer fps to eliminate any config. Things change randomly (at least under NLC testing) which makes it hard to rely on inter-layer. And browser variations like some browsers stopping lower layers makes it error prone.
The single config of
MinFPSwith sane defaults seems like it could be the way. Hopefully, the default will be good for an overwhelming majoirty of use cases. If not, we can look at adding one config toVideoLayersinTrackInfoforMinFPSand override the server side config per track. That is a small enough change to the protocol and fairly straight forward to document/understand.