Do not include packet in RED if timestamp is too far back. #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boks1971
commented
Feb 28, 2023
| } | ||
| r.pktBuff[i] = pkt | ||
| break | ||
| } |
There was a problem hiding this comment.
Re-doing this a bit to catch scenarios like following
- Packet arrival sequence is 5, 7, 6
- When 6 is received, the history would have 5, 7
- RED encoding would have been 5, 6 (only one redundancy)
- Previously, the history would not have been changed as 6 is out-of-order with the last element. So, when 8 was received, it would have been encoded as 7, 8 (only one redundancy as 5 is too old)
Changing it to walk back and find a location for the new packet. So, after 6, the history would be 6, 7 and when 8 comes around it can be encoded with 6, 7, 8 (two redundancies)
cnderrauber
approved these changes
Feb 28, 2023
Will add a test case @cnderrauber |
@cnderrauber Added a test case in this commit (ac5721d). Can you please review when you get a chance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.