Prevent PLI layer lock getting stuck. #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the following scenario, PLI layer lock got stuck at the wrong layer - target is at 2 to allow overshoot - current gets to 1, but can't get higher because publisher is not publishing higher layer - max layer changed to 0 Because of adjusting for overshoot only when current == target, it never happened and layer lock PLI kept asking for layer 0. Although, key frames were received, switch did not happen. Always check for overshoot adjustment possibility against current layer.
davidzhao
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the following scenario, PLI layer lock got stuck at the wrong layer
Because of adjusting for overshoot only when current == target, it never happened and layer lock PLI kept asking for layer 0. Although, key frames were received, switch did not happen.
Always check for overshoot adjustment possibility against current layer.