Don't switch candidate if signal closed when pc failed #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boks1971
approved these changes
Mar 7, 2023
davidzhao
approved these changes
Mar 7, 2023
| @@ -339,6 +341,7 @@ func (r *Room) Join(participant types.LocalParticipant, opts *ParticipantOptions | |||
|
|
|||
| r.participants[participant.Identity()] = participant | |||
| r.participantOpts[participant.Identity()] = opts | |||
| r.participantRequestSources[participant.Identity()] = requestSource | |||
There was a problem hiding this comment.
should this be a field inside participantOpts instead? could simplify the interface by keeping it the same.
There was a problem hiding this comment.
The ParticipantOpts is used to save options provided by the client connection option, I prefer to separate internal state from it, what we are doing at cloud.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.