Fix sequence number offset on packet drop #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boks1971
commented
Mar 28, 2023
| r.snOffsetsOccupancy-- | ||
| if r.snOffsetsOccupancy < 0 { | ||
| r.logger.Warnw("sequence number offset cache is invalid", nil, "occupancy", r.snOffsetsOccupancy) | ||
| } |
There was a problem hiding this comment.
This is the main fix.
boks1971
commented
Mar 28, 2023
| @@ -1110,7 +1108,7 @@ func (s *StreamAllocator) initProbe(probeRateBps int64) { | |||
| "committed", s.committedChannelCapacity, | |||
| "lastReceived", s.lastReceivedEstimate, | |||
| "probeRateBps", probeRateBps, | |||
| "goalBps", expectedBandwidthUsage+probeRateBps, | |||
| "goalBps", s.probeGoalBps, | |||
There was a problem hiding this comment.
fixing some logging bits - drive by (actually was working on stream allocator tweaks and had a couple of useful prints for collecting more data, so including here).
cnderrauber
approved these changes
Mar 29, 2023
paulwe
pushed a commit
that referenced
this pull request
Apr 6, 2023
hautvfami
pushed a commit
to Stark-Industries-Ltd/livekit
that referenced
this pull request
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All sequence numbers are stored in sequence number offset array. So, the offset write ptr should not be adjusted on packet drop. This was causing sequence numbers to get out of whack in lossy network + congestion case. And that caused PLIs to be generated.
NOTE: Still not able to reproduce the glut of PLIs, but this is one reason for PLIs.
Also made the VP8 munger under loss more resilient. Comments in code.
Enhanced RTPMunger UT to check for more sequence number offsets/write pointer.