Support simulating subscriber bandwidth. #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When non-zero, a full allocation is triggered. Also, probes are stopped. When set to zero, normal probing mechanism should catch up. Adding `allowPause` override which can be a connection option.
davidzhao
approved these changes
Apr 13, 2023
pkg/rtc/room.go
Outdated
| @@ -692,7 +692,7 @@ func (r *Room) OnMetadataUpdate(f func(metadata string)) { | |||
| func (r *Room) SimulateScenario(participant types.LocalParticipant, simulateScenario *livekit.SimulateScenario) error { | |||
| switch scenario := simulateScenario.Scenario.(type) { | |||
| case *livekit.SimulateScenario_SpeakerUpdate: | |||
| r.Logger.Infow("simulating speaker update", "participant", participant.Identity()) | |||
| r.Logger.Infow("simulating speaker update", "participant", participant.Identity(), "after", scenario.SpeakerUpdate) | |||
There was a problem hiding this comment.
nit: I think this is the duration of the simulation
hautvfami
pushed a commit
to Stark-Industries-Ltd/livekit
that referenced
this pull request
Jul 21, 2023
* Support simualting subscriber bandwidth. When non-zero, a full allocation is triggered. Also, probes are stopped. When set to zero, normal probing mechanism should catch up. Adding `allowPause` override which can be a connection option. * fix log * allowPause in participant params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When non-zero, a full allocation is triggered.
Also, probes are stopped.
When set to zero, normal probing mechanism should catch up.
Adding
allowPauseoverride which can be a connection option.